netdev - question on smsc95xx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <200901151728.19899.oliver@neukum.org>
Date:	Thu, 15 Jan 2009 17:28:19 +0100
From:	Oliver Neukum <oliver@...kum.org>
To:	steve.glendinning@...c.com, netdev@...r.kernel.org,
	linux-usb@...r.kernel.org
Subject: question on smsc95xx

Hi,

I am looking at this code:

static void smsc95xx_async_cmd_callback(struct urb *urb, struct pt_regs *regs)
{
	struct usb_context *usb_context = urb->context;
	struct usbnet *dev = usb_context->dev;
	int status = urb->status;

	if (status < 0)
		devwarn(dev, "async callback failed with %d", status);

	complete(&usb_context->notify);

is there some ultradeep reason for using complete here?
I cannot see that serving any purpose whatsoever.

	Regards
		Oliver
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html