netdev - Re: sfc: Replace LRO with GRO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090119.132929.108799868.davem@davemloft.net>
Date:	Mon, 19 Jan 2009 13:29:29 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	bhutchings@...arflare.com
Cc:	herbert@...dor.apana.org.au, netdev@...r.kernel.org
Subject: Re: sfc: Replace LRO with GRO

From: Ben Hutchings <bhutchings@...arflare.com>
Date: Mon, 19 Jan 2009 14:40:06 +0000

> On Sun, 2009-01-18 at 21:50 -0800, David Miller wrote:
> > From: Herbert Xu <herbert@...dor.apana.org.au>
> > Date: Thu, 15 Jan 2009 15:24:22 +1100
> > 
> > > sfc: Replace LRO with GRO
> > > 
> > > This patch makes sfc invoke the GRO hooks instead of LRO.  As
> > > GRO has a compatible external interface to LRO this is a very
> > > straightforward replacement.
> > > 
> > > Everything should appear identical to the user except that the
> > > offload is now controlled by the GRO ethtool option instead of
> > > LRO.  I've kept the lro module parameter as is since that's for
> > > compatibility only.
> > > 
> > > I have eliminated efx_rx_mk_skb as the GRO layer can take care
> > > of all packets regardless of whether GRO is enabled or not.
> > > 
> > > So the only case where we don't call GRO is if the packet checksum
> > > is absent.  This is to keep the behaviour changes of the patch to
> > > a minimum.
> > > 
> > > Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au>
> > 
> > Applied for 2.6.30
> 
> Please could you push this and other GRO changes for .30 to
> net-next-2.6?

All of Herbert's bug fixes are going into net-2.6, and that's
where they will stay.

I haven't published my net-next-2.6 tree at all, because
Stephen Rothwell hasn't stated that such content is
OK yet for his -next tree.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html