netdev - Re: [PATCH 1/9] bnx2x: remove a few trivial macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1232646546.29087.84.camel@lb-tlvb-eliezer>
Date:	Thu, 22 Jan 2009 19:49:06 +0200
From:	"Eilon Greenstein" <eilong@...adcom.com>
To:	"Harvey Harrison" <harvey.harrison@...il.com>
cc:	linux-netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH 1/9] bnx2x: remove a few trivial macros

On Tue, 2009-01-20 at 21:50 -0800, Harvey Harrison wrote:
> Signed-off-by: Harvey Harrison <harvey.harrison@...il.com>
> ---
> Eilon, after this series, sparse with endian-checking at least gets through a
> compile without hitting too many errors, patch 9 is a functional change
> and may have exposed an endian bug in the driver....but I had to get through
> the other 8 to see it ;-)
> 
> patches 1-8 shouldn't change any behavior...if it does it wasn't intentional.
> 
>  drivers/net/bnx2x.h      |    4 ---
>  drivers/net/bnx2x_main.c |   62 +++++++++++++++++++++++-----------------------
>  2 files changed, 31 insertions(+), 35 deletions(-)

Thanks Harvey! This change looks good

Acked-by: Eilon Greenstein <eilong@...adcom.com>


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html