netdev - Re: [PATCH 1/9] bnx2x: remove a few trivial macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1232646606.29087.91.camel@lb-tlvb-eliezer>
Date:	Thu, 22 Jan 2009 19:50:06 +0200
From:	"Eilon Greenstein" <eilong@...adcom.com>
To:	"David Miller" <davem@...emloft.net>
cc:	"harvey.harrison@...il.com" <harvey.harrison@...il.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH 1/9] bnx2x: remove a few trivial macros

On Wed, 2009-01-21 at 15:42 -0800, David Miller wrote:
> From: "Eilon Greenstein" <eilong@...adcom.com>
> Date: Wed, 21 Jan 2009 09:14:53 +0200
> 
> > On Tue, 2009-01-20 at 21:50 -0800, Harvey Harrison wrote:
> > > Signed-off-by: Harvey Harrison <harvey.harrison@...il.com>
> > > ---
> > > Eilon, after this series, sparse with endian-checking at least gets through a
> > > compile without hitting too many errors, patch 9 is a functional change
> > > and may have exposed an endian bug in the driver....but I had to get through
> > > the other 8 to see it ;-)
> > > 
> > Wooh!!! Harvey - thanks for all the hard work!
> > 
> > I will review it carefully and start regression tests on few different
> > platforms to verify this fix. Stay tuned.
> 
> Thanks Eilon, once you've validated these changes let me know
> so I can add them to net-next-2.6
> 

Besides the eeprom changes that broke a utility that uses it, this patch
is working just fine. I have few cosmetic issues with le_to_cpu for zero
(which I plan to remove) and I'm not sure if replacing swab with
cpu_to_le on top of be_to_cpu is the way to go - I hope to get some
comments on this one.

Harvey - I truly appreciate your work. I will pack it and resend it
after receiving some comments.

Thanks again,
Eilon


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html