netdev - Re: [PATCH 8/9] bnx2x: further annotations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1232646594.29087.88.camel@lb-tlvb-eliezer>
Date:	Thu, 22 Jan 2009 19:49:53 +0200
From:	"Eilon Greenstein" <eilong@...adcom.com>
To:	"Harvey Harrison" <harvey.harrison@...il.com>
cc:	linux-netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH 8/9] bnx2x: further annotations

On Tue, 2009-01-20 at 21:50 -0800, Harvey Harrison wrote:
> No functional annotations, just documenting the status quo.
> 
> Signed-off-by: Harvey Harrison <harvey.harrison@...il.com>

[...]

> @@ -9699,11 +9699,11 @@ static int bnx2x_start_xmit(struct sk_buff *skb, struct net_device *dev)
>  						 bd_prod, ++nbd);
>  
>  		pbd->lso_mss = cpu_to_le16(skb_shinfo(skb)->gso_size);
> -		pbd->tcp_send_seq = swab32(tcp_hdr(skb)->seq);
> +		pbd->tcp_send_seq = cpu_to_le32(be32_to_cpu(tcp_hdr(skb)->seq));

Hmmm.... That looks worse to me. Do we really need to replace swab with
cpu_to_le on top of be_to_cpu?

>  		pbd->tcp_flags = pbd_tcp_flags(skb);
>  
>  		if (xmit_type & XMIT_GSO_V4) {
> -			pbd->ip_id = swab16(ip_hdr(skb)->id);
> +			pbd->ip_id = cpu_to_le16(be16_to_cpu(ip_hdr(skb)->id));

Same question

>  			pbd->tcp_pseudo_csum =
>  				swab16(~csum_tcpudp_magic(ip_hdr(skb)->saddr,
>  							  ip_hdr(skb)->daddr,


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html