netdev - Re: [PANIC] lro + iscsi or lro + skb text search causes panic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49794612.9010204@cs.wisc.edu>
Date:	Thu, 22 Jan 2009 22:22:42 -0600
From:	Mike Christie <michaelc@...wisc.edu>
To:	"Brandeburg, Jesse" <jesse.brandeburg@...el.com>
CC:	netdev@...r.kernel.org, olaf.kirch@...cle.com, tgraf@...g.ch,
	kkeil@...e.de, herbert@...dor.apana.org.au
Subject: Re: [PANIC] lro + iscsi or lro + skb text search causes panic

Mike Christie wrote:
> Brandeburg, Jesse wrote:
>>
>> skb_copy_bits is an example of the code flow that does work.
>>
>> skb_seq_read appears to only be used by iSCSI and the skb text match 
>> support in tc/netfilter (aka skb_find_text)
>>
> 
> There is no reason iscsi needs to use skb_seq_read. It used to use 
> skb_copy_bits. I can convert iscsi to use skb_copy_bits again.
> 

Attached is a patch made against the scsi maintainer's tree (I think it 
should also apply to linus's) that converts iscsi to use skb_copy_bits. 
It is lightly tested. If there is no benefit in having skb_find_text use 
skb_seq_read maybe we can just kill it, so people do not have to 
maintain two helpers that provide similar functionality.

View attachment "use-skb-copy-bits.patch" of type "text/plain" (4906 bytes)