netdev - RE: [PATCH] gianfar: Revive VLAN support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <18AEF66AFDF06F4CAAA1D419D000FD33029D5F46@az33exm24.fsl.freescale.net>
Date:	Mon, 26 Jan 2009 16:39:55 -0700
From:	"Haruki Dai" <Dai.Haruki@...escale.com>
To:	"Fleming Andy-AFLEMING" <afleming@...escale.com>,
	"Anton Vorontsov" <avorontsov@...mvista.com>
Cc:	"Jeff Garzik" <jgarzik@...ox.com>,
	"David Miller" <davem@...emloft.net>, <netdev@...r.kernel.org>,
	<linuxppc-dev@...abs.org>
Subject: RE: [PATCH] gianfar: Revive VLAN support

> -----Original Message-----
> From: Fleming Andy-AFLEMING
> Sent: Monday, January 26, 2009 3:08 PM
> To: Anton Vorontsov
> Cc: Jeff Garzik; David Miller; Haruki Dai-R35557;
netdev@...r.kernel.org;
> linuxppc-dev@...abs.org
> Subject: Re: [PATCH] gianfar: Revive VLAN support
> 
> 
> On Jan 26, 2009, at 2:50 PM, Anton Vorontsov wrote:
> 
> > commit 77ecaf2d5a8bfd548eed3f05c1c2e6573d5de4ba ("gianfar: Fix VLAN
> > HW feature related frame/buffer size calculation") wrongly removed
> > priv->vlgrp assignment, and now priv->vlgrp is always NULL.
> >
> > This patch fixes the issue, plus fixes following sparse warning
> > introduced by the same commit:
> > gianfar.c:1406:13: warning: context imbalance in
> > 'gfar_vlan_rx_register' - wrong count at exit
> >
> > gfar_vlan_rx_register() checks for "if (old_grp == grp)" and tries
> > to return w/o dropping the lock.
> >
> > According to net/8021q/vlan.c VLAN core issues rx_register()
callback:
> > 1. In register_vlan_dev() only on a newly created group;
> > 2. In unregister_vlan_dev() only if the group becomes empty.
> >
> > Thus the check in the gianfar driver isn't needed.
> >
> > Signed-off-by: Anton Vorontsov <avorontsov@...mvista.com>
> 
> Acked-by: Andy Fleming <afleming@...escale.com>

Acked-by: Dai Haruki <dai.haruki@...escale.com>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html