netdev - Re: [PATCH 04/21] RDS: Transport code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c0a09e5c0901271136h4ac81f28g143d1b084cc1076@mail.gmail.com>
Date:	Tue, 27 Jan 2009 11:36:37 -0800
From:	Andrew Grover <andy.grover@...il.com>
To:	Evgeniy Polyakov <zbr@...emap.net>
Cc:	Andy Grover <andy.grover@...cle.com>, rdreier@...co.com,
	rds-devel@....oracle.com, general@...ts.openfabrics.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH 04/21] RDS: Transport code

On Tue, Jan 27, 2009 at 5:18 AM, Evgeniy Polyakov <zbr@...emap.net> wrote:
> On Mon, Jan 26, 2009 at 06:17:41PM -0800, Andy Grover (andy.grover@...cle.com) wrote:
>> +static LIST_HEAD(transports);
>> +static DECLARE_RWSEM(trans_sem);
>> +
>
> RDS_ prefix?

Even needed for statics?

>> +int rds_trans_register(struct rds_transport *trans)
>> +{
>> +     BUG_ON(strlen(trans->t_name) + 1 >
>> +            sizeof(((struct rds_info_connection *)0)->transport));
>> +
>
> Wow. Why not declare 15 as some constant and put it into rds_transport
> structure definition?

Makes sense.

>> +        if (IN_LOOPBACK(ntohl(addr)))
>> +                return &rds_loop_transport;
>> +
>
> Tabs have run away.

Will fix. Thanks.

Regards -- Andy
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html