netdev - Re: [PATCH 04/21] RDS: Transport code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090127215657.GD12431@ioremap.net>
Date:	Wed, 28 Jan 2009 00:56:58 +0300
From:	Evgeniy Polyakov <zbr@...emap.net>
To:	Andrew Grover <andy.grover@...il.com>
Cc:	Andy Grover <andy.grover@...cle.com>, rdreier@...co.com,
	rds-devel@....oracle.com, general@...ts.openfabrics.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH 04/21] RDS: Transport code

On Tue, Jan 27, 2009 at 11:36:37AM -0800, Andrew Grover (andy.grover@...il.com) wrote:
> On Tue, Jan 27, 2009 at 5:18 AM, Evgeniy Polyakov <zbr@...emap.net> wrote:
> > On Mon, Jan 26, 2009 at 06:17:41PM -0800, Andy Grover (andy.grover@...cle.com) wrote:
> >> +static LIST_HEAD(transports);
> >> +static DECLARE_RWSEM(trans_sem);
> >> +
> >
> > RDS_ prefix?
> 
> Even needed for statics?

It confuses tags and the like otherwise, and looks more consistent with
the rest of the code. Likely it is not a must, but just better look.

-- 
	Evgeniy Polyakov
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html