netdev - Re: [PATCH 1/4]: net: Allow RX queue selection to seed TX queue hashing.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090128213141.GD22141@gondor.apana.org.au>
Date:	Thu, 29 Jan 2009 08:31:41 +1100
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 1/4]: net: Allow RX queue selection to seed TX queue
	hashing.

On Wed, Jan 28, 2009 at 12:22:31PM -0800, David Miller wrote:
>
> No matter what you think about the randomness aspect, our
> divide avoidance technique being used here will still
> get in the way of the situations you seem to be concerned
> about.
> 
> We do the jhash et al. magic in order to be able to use a
> multiply to get the modulus.  So the function computing from
> RX to TX queue numbers will never be straightforward.

Right, if the number of queues weren't equal then clearly it's
not an issue to tack on more randomness.  But I was thinking of
scenarios where you have two identical NICs, performing routing
where the number of queues is likely to be identical.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html