netdev - Re: [PATCH 1/4]: net: Allow RX queue selection to seed TX queue hashing.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090128.122231.208600152.davem@davemloft.net>
Date:	Wed, 28 Jan 2009 12:22:31 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	herbert@...dor.apana.org.au
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 1/4]: net: Allow RX queue selection to seed TX queue
 hashing.

From: Herbert Xu <herbert@...dor.apana.org.au>
Date: Wed, 28 Jan 2009 19:53:58 +1100

> So can you think of a scenario where we really need this added
> protection?

No matter what you think about the randomness aspect, our
divide avoidance technique being used here will still
get in the way of the situations you seem to be concerned
about.

We do the jhash et al. magic in order to be able to use a
multiply to get the modulus.  So the function computing from
RX to TX queue numbers will never be straightforward.

And since we do need to do the jhash to make that multiply
trick work, the randomness comes essentially for free and
does not make the RX to TX queue relationship any more or
less straightforward.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html