netdev - Re: [PATCH] forcedeth: mgmt unit interface changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090127.172944.219399602.davem@davemloft.net>
Date:	Tue, 27 Jan 2009 17:29:44 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	akpm@...ux-foundation.org
Cc:	aabdulla@...dia.com, manfred@...orfullife.com, jgarzik@...ox.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH] forcedeth: mgmt unit interface changes

From: Andrew Morton <akpm@...ux-foundation.org>
Date: Tue, 27 Jan 2009 17:27:05 -0800

> whee, a 50 second busy-wait.
> 
> Unnecessarily, afacit.  The sole caller calls this function from
> ->probe without any locks held?
> 
> I'd suggest that we
> 
> a) use schedule_timeout_uninterruptible(1) and
> 
> b) add a bit of user feedback (printk(".")?) so they don't get bored
> and hit the reset button (remember those?)

Agreed.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html