lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 27 Jan 2009 17:34:45 -0800 From: Ayaz Abdulla <AAbdulla@...dia.com> To: 'David Miller' <davem@...emloft.net>, "akpm@...ux-foundation.org" <akpm@...ux-foundation.org> CC: "manfred@...orfullife.com" <manfred@...orfullife.com>, "jgarzik@...ox.com" <jgarzik@...ox.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org> Subject: RE: [PATCH] forcedeth: mgmt unit interface changes Yes, good catch. One extra zero added, should be only upto 5 secs. I will resend the patch. -----Original Message----- From: David Miller [mailto:davem@...emloft.net] Sent: Tuesday, January 27, 2009 5:30 PM To: akpm@...ux-foundation.org Cc: Ayaz Abdulla; manfred@...orfullife.com; jgarzik@...ox.com; netdev@...r.kernel.org Subject: Re: [PATCH] forcedeth: mgmt unit interface changes From: Andrew Morton <akpm@...ux-foundation.org> Date: Tue, 27 Jan 2009 17:27:05 -0800 > whee, a 50 second busy-wait. > > Unnecessarily, afacit. The sole caller calls this function from > ->probe without any locks held? > > I'd suggest that we > > a) use schedule_timeout_uninterruptible(1) and > > b) add a bit of user feedback (printk(".")?) so they don't get bored > and hit the reset button (remember those?) Agreed. ----------------------------------------------------------------------------------- This email message is for the sole use of the intended recipient(s) and may contain confidential information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply email and destroy all copies of the original message. ----------------------------------------------------------------------------------- -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists