netdev - Re: [ofa-general] NetEffect, iw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090128110514.2191c7a8@extreme>
Date:	Wed, 28 Jan 2009 11:05:14 -0800
From:	Stephen Hemminger <shemminger@...tta.com>
To:	Roland Dreier <rdreier@...co.com>
Cc:	David Miller <davem@...emloft.net>, aluno3@...zta.onet.pl,
	general@...ts.openfabrics.org, netdev@...r.kernel.org
Subject: Re: [ofa-general] NetEffect, iw_nes and kernel warning

On Wed, 28 Jan 2009 10:05:29 -0800
Roland Dreier <rdreier@...co.com> wrote:

>  > > but actually I still don't see how it's safe for a net driver to
>  > > call skb_linearize() from its transmit routine, since there's a
>  > > chance that that will unconditionally enable BHs?
>  > 
>  > It's simply not allowed.
>  > 
>  > dev_queue_xmit() at a higher level can do __skb_linearize()
>  > because it does so before doing the rcu_read_lock_bh().
> 
> OK, thanks... what confused me is that several other drivers also do
> skb_linearize() in their hard_start_xmit method... eg bnx2x,
> via-velocity, mv643xx_eth.  So there are several other lurking bugs to
> deal with here I guess.
> 
>  - R.

They all look like lurking (and untested) bug paths. mv643xx is especially
bad since it can leak skb. But it should be possible to call pull_tail
if bh is disabled (as long as irqs are enabled).
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html