[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <200902050026.46603.denys@visp.net.lb>
Date: Thu, 5 Feb 2009 00:26:46 +0200
From: Denys Fedoryschenko <denys@...p.net.lb>
To: Jarek Poplawski <jarkao2@...il.com>
Cc: Stephen Hemminger <shemminger@...ux-foundation.org>,
netdev@...r.kernel.org
Subject: Re: [PATCH] [RESEND] iproute2 : invalid burst/cburst calculation with hrtimers
On Wednesday 04 February 2009 23:53:14 Jarek Poplawski wrote:
> Jarek Poplawski wrote, On 02/04/2009 10:20 PM:
> > Denys Fedoryschenko wrote, On 02/02/2009 07:21 PM:
> >> Why floating point?
> >
> > Yes, floating point is not enough. get_hz() == 1000000000 could be
> > a theoretical resolution, but I guess we don't expect to use this,
> > even if it were possible. Since high resolution can schedule more
> > often than 1000HZ, it seems these buffers could be set lower (10x,
> > 100x?), but there should be some reasonable limit.
>
> Anyway, it's rather a matter of tweaking. IMHO 1000HZ limit for setting
> these defaults looks safe, so I think this patch is OK.
>
> Jarek P.
Maybe we can put note in documentation or even htb help output, that user can
increase precision with hrtimers enabled, by setting HZ variable?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists