netdev - Re: [PATCH] [RESEND] iproute2 : invalid burst/cburst calculation with hrtimers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090205100853.GB4305@ff.dom.local>
Date:	Thu, 5 Feb 2009 10:08:53 +0000
From:	Jarek Poplawski <jarkao2@...il.com>
To:	Denys Fedoryschenko <denys@...p.net.lb>
Cc:	Stephen Hemminger <shemminger@...ux-foundation.org>,
	netdev@...r.kernel.org
Subject: Re: [PATCH] [RESEND] iproute2 : invalid burst/cburst calculation
	with hrtimers

On Thu, Feb 05, 2009 at 11:01:35AM +0200, Denys Fedoryschenko wrote:
> Well, i don't know well what's wrong, but:
> 
> I have enough powerful router, 2x Quad Core 2 - 2.8 Ghz
> 4 x e1000e
> 
> And if i just try to shape interface for 200 Mbps with default iproute2 from 
> git (and latest stable release same situation), i am getting too low 
> burst/cburst. Sometimes it is even miscalculated (it can become 1500 byte, 
> sometimes, while 1600 is minimum) , because yes, Stephen right, it needs 
> float.
> BUT.
> Even i set manually twice more burst/cburst, it is just not enough for 200 
> Mbps. I am checking on Cisco, rate is reaching max 180-185Mbps, and even on 
> this rate buffering in qdiscs and as result jittering hard.
> So this 100 bytes, which probably missing, really doesn't matter.
> 
> With 1000 HZ i have
> class htb 1:10 parent 1:2 rate 220000Kbit ceil 220000Kbit burst 29067b cburst 
> 29067b
>  Sent 14027734219153 bytes 590886842 pkt (dropped 0, overlimits 0 requeues 0)
>  rate 122452Kbit 17131pps backlog 0b 0p requeues 0
>  lended: 171333348 borrowed: 0 giants: 0
>  tokens: 980 ctokens: 980
> 
> And it works quite well and precise.

I lost your point... I think it's just like in your (and Martin's)
description to your patch. Plus you wrote it was tested OK?!

BTW, did you try to set the same (29kb) burst/cburst manually? Did
you try with half of it (15kb)?

> P.S. Maybe a case, when some guy was not able to reach his gigabit with HTB 
> shaper, i remember there was flowing some discussing, was somehow similar as 
> my case.

I don't remember this, but with current defaults it's really a problem
for higher rates.

Jarek P.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html