netdev - Re: [PATCH] [RESEND] iproute2 : invalid burst/cburst calculation with hrtimers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200902051309.06958.denys@visp.net.lb>
Date:	Thu, 5 Feb 2009 13:09:06 +0200
From:	Denys Fedoryschenko <denys@...p.net.lb>
To:	Jarek Poplawski <jarkao2@...il.com>
Cc:	Stephen Hemminger <shemminger@...ux-foundation.org>,
	netdev@...r.kernel.org
Subject: Re: [PATCH] [RESEND] iproute2 : invalid burst/cburst calculation with hrtimers

On Thursday 05 February 2009 12:08:53 Jarek Poplawski wrote:
>
> I lost your point... I think it's just like in your (and Martin's)
> description to your patch. Plus you wrote it was tested OK?!
Martin just pointed me, that burst/cburst probably is too small.

I found, that it is too small because of get_hz(). Actually on highres it will 
be always 1600 (default minimal value).

>
> BTW, did you try to set the same (29kb) burst/cburst manually? Did
> you try with half of it (15kb)?
I didn't, i guess i must calculate corresponding rates for another classes 
equally. But i try to set HZ variable to 2000 for example, i will see:

class htb 1:10 parent 1:2 rate 220000Kbit ceil 220000Kbit burst 15317b cburst 
15317b
 Sent 100864803 bytes 115615 pkt (dropped 0, overlimits 0 requeues 0)
 rate 15426Kbit 2106pps backlog 0b 0p requeues 0
 lended: 29467 borrowed: 0 giants: 0
 tokens: 533 ctokens: 533

But it is difficult to know, if it works fine or not. I will try to do more 
tests for 2000 and 10000 HZ. The issue, that on that point where i had fault, 
now is less load, so i have to find another place where i can test 
differences.

>
> > P.S. Maybe a case, when some guy was not able to reach his gigabit with
> > HTB shaper, i remember there was flowing some discussing, was somehow
> > similar as my case.
>
> I don't remember this, but with current defaults it's really a problem
> for higher rates.
>
> Jarek P.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html