netdev - Re: [PATCH] Update jhash.h with the new version of Jenkins' hash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4991EF7B.90004@cisco.com>
Date:	Tue, 10 Feb 2009 13:19:55 -0800
From:	Scott Feldman <scofeldm@...co.com>
To:	Jozsef Kadlecsik <kadlec@...ckhole.kfki.hu>
CC:	davem@...emloft.net, netdev@...r.kernel.org,
	netfilter-devel@...r.kernel.org
Subject: Re: [PATCH] Update jhash.h with the new version of Jenkins' hash

Jozsef Kadlecsik wrote:
> The patch replaces the lookup2() implementation of the 'jhash*' 
> functions with that of lookup3().

Should the lookup3() be added to rather than replacing lookup2()?  In 
case some hardware vendor used the lookup2() version for weird things 
like flow classification.

>  /* The golden ration: an arbitrary value */
> -#define JHASH_GOLDEN_RATIO	0x9e3779b9
> +#define JHASH_GOLDEN_RATIO	0xdeadbeef

The #define seems mis-named now.

-scott
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html