netdev - Re: [PATCH] drivers/isdn/hardware/mISDN: fix sparse warnings: make symbols static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49954606.9080204@gmail.com>
Date:	Fri, 13 Feb 2009 11:05:58 +0100
From:	Jiri Slaby <jirislaby@...il.com>
To:	Hannes Eder <hannes@...neseder.net>
CC:	netdev@...r.kernel.org, kernel-janitors@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers/isdn/hardware/mISDN: fix sparse warnings: make
 symbols static

On 02/12/2009 08:28 PM, Hannes Eder wrote:
> diff --git a/drivers/isdn/hardware/mISDN/hfcpci.c b/drivers/isdn/hardware/mISDN/hfcpci.c
> index f0e14df..2bb85c4 100644
> --- a/drivers/isdn/hardware/mISDN/hfcpci.c
> +++ b/drivers/isdn/hardware/mISDN/hfcpci.c
> @@ -56,8 +56,8 @@ static const char *hfcpci_revision = "2.0";
>  static int HFC_cnt;
>  static uint debug;
>  static uint poll, tics;
> -struct timer_list hfc_tl;
> -u32	hfc_jiffies;
> +static struct timer_list hfc_tl;
> +static u32 hfc_jiffies;

Please also fix the hfc_jiffies type (ulong). (As a separate patch.)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html