netdev - [PATCH] b44: Disable device on shutdown (Resend)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <1295ed070902150603u784fe48dg47719647cd8cafed@mail.gmail.com>
Date:	Sun, 15 Feb 2009 16:03:29 +0200
From:	Pantelis Koukousoulas <pktoss@...il.com>
To:	netdev@...r.kernel.org
Subject: [PATCH] b44: Disable device on shutdown (Resend)

Hi!

There's been about 3 months since the last time this patch was sent,
so I assume it was lost in the
queue or something.

Please consider applying. It is only a one-liner, It fixes a real WTF-type bug
(modprobe -r b44 && modprobe b44 and boom! no internet!)
and I 've been testing, using and carrying it along for the last 3 months
(not to mention having to spend the time to debug it in the first place :-)

It is a regression from 2.6.24 IIRC (when b44 was ported to the ssb
stack) and the patch is
authored by the guy who wrote this port.

Currently this and the other b44 patch I 'm going to resend next are
the only things that make
me maintain a custom kernel.

Thanks in advance,
Pantelis

---------- Forwarded message ----------
From: Michael Buesch <mb@...sch.de>
Date: Sun, Nov 16, 2008 at 4:39 PM
Subject: [PATCH] b44: Disable device on shutdown
To: Jeff Garzik <jeff@...zik.org>
Cc: netdev@...r.kernel.org, Pantelis Koukousoulas <pktoss@...il.com>,
Gary Zambrano <zambrano@...adcom.com>, stable@...nel.org

Disable the SSB core on device shutdown.
This has two advantages:
1) A clean device shutdown is always desired here, because we disable
  the device's global crystal in the next statement.
2) This fixes a bug where the device will come up with the enable-bit
  set on the next initialization (without a reboot inbetween).
  This causes breakage on the second initialization due to code that
  checks this bit (ssb_device_is_enabled() checks).

Reported-by: Pantelis Koukousoulas <pktoss@...il.com>
Signed-off-by: Michael Buesch <mb@...sch.de>
Cc: stable@...nel.org

---

I think this should go in for 2.6.28, as it fixes a
device-doesn't-work-anymore bug after a insmod-rmmod-insmod cycle.

Index: wireless-testing/drivers/net/b44.c
===================================================================
--- wireless-testing.orig/drivers/net/b44.c     2008-11-16
14:45:08.000000000 +0100
+++ wireless-testing/drivers/net/b44.c  2008-11-16 14:47:06.000000000 +0100
@@ -2233,6 +2233,7 @@ static void __devexit b44_remove_one(str
       struct net_device *dev = ssb_get_drvdata(sdev);

       unregister_netdev(dev);
+       ssb_device_disable(sdev, 0);
       ssb_bus_may_powerdown(sdev->bus);
       free_netdev(dev);
       ssb_pcihost_set_power_state(sdev, PCI_D3hot);

--
Greetings Michael.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html