netdev - Re: [PATCH] netlink: add NETLINK_BROADCAST_REPORT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49994A70.5000502@trash.net>
Date:	Mon, 16 Feb 2009 12:13:52 +0100
From:	Patrick McHardy <kaber@...sh.net>
To:	Pablo Neira Ayuso <pablo@...filter.org>
CC:	netdev@...r.kernel.org, davem@...emloft.net
Subject: Re: [PATCH] netlink: add NETLINK_BROADCAST_REPORT_ERROR socket option

Pablo Neira Ayuso wrote:
> diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c
> index 6ee69c2..29dd4fb 100644
> --- a/net/netlink/af_netlink.c
> +++ b/net/netlink/af_netlink.c
> @@ -85,6 +85,7 @@ struct netlink_sock {
>  
>  #define NETLINK_KERNEL_SOCKET	0x1
>  #define NETLINK_RECV_PKTINFO	0x2
> +#define NETLINK_BROADCAST_SEND_REPORT_ERROR	0x4

The name seems to imply send twice (send/report).

>  static inline struct netlink_sock *nlk_sk(struct sock *sk)
>  {
> @@ -994,13 +995,15 @@ static inline int do_one_broadcast(struct sock *sk,
>  	if (p->skb2 == NULL) {
>  		netlink_overrun(sk);
>  		/* Clone failed. Notify ALL listeners. */
> -		p->failure = 1;
> +		if (nlk->flags & NETLINK_BROADCAST_SEND_REPORT_ERROR)
> +			p->failure = 1;

This doesn't make sense. *Other* sockets get skipped only iff
this socket had the error-report flag set? This should be done
in a consistent manner, which means either not set the failure
flag at all and retry for all sockets, or set it for any failed
socket delivery and determine the return value based on whether
one of the skipped sockets had the error-report flag set.

>  	} else if (sk_filter(sk, p->skb2)) {
>  		kfree_skb(p->skb2);
>  		p->skb2 = NULL;
>  	} else if ((val = netlink_broadcast_deliver(sk, p->skb2)) < 0) {
>  		netlink_overrun(sk);
> -		p->delivery_failure = 1;
> +		if (nlk->flags & NETLINK_BROADCAST_SEND_REPORT_ERROR)
> +			p->delivery_failure = 1;
>  	} else {
>  		p->congested |= val;
>  		p->delivered = 1;
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html