netdev - Re: [net-next PATCH 2/2] ixgbe: fix for 82598 Si errata causing buffer overflow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20090221.154305.237729082.davem@davemloft.net>
Date:	Sat, 21 Feb 2009 15:43:05 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	jeffrey.t.kirsher@...el.com
Cc:	netdev@...r.kernel.org, gospo@...hat.com,
	donald.c.skidmore@...el.com, peter.p.waskiewicz.jr@...el.com
Subject: Re: [net-next PATCH 2/2] ixgbe: fix for 82598 Si errata causing
 buffer overflow

From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Date: Sat, 21 Feb 2009 14:23:40 -0800

> The failure happens when an interrupt occurs and the driver is reading
> EICR.  This read will cause a clear-by-read which leads to two TLP
> being inserted in the PCIe retry buffer leading to an overflow of the
> buffer and corruption of TLPs.
> 
> The solution is different depending where the reading of EICR takes place.
> 
> For ixgbe_msix_lsc() since we are in MSIX mode and know OCD is enabled a
> clear-by-write is done instead of the normal clear-by-read.
> 
> For ixgbe_intr() 0xffffffff is written to EIMC before the read, masking the
> interrupts.
> 
> Signed-off-by: Don Skidmore <donald.c.skidmore@...el.com>
> Acked-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@...el.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html