netdev - Re: [net-next PATCH] igb: remove skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090227031421.GA21036@gondor.apana.org.au>
Date:	Fri, 27 Feb 2009 11:14:21 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	"Duyck, Alexander H" <alexander.h.duyck@...el.com>
Cc:	jeffrey.t.kirsher@...el.com, davem@...emloft.net,
	emil.s.tantilov@...el.com, patrick.ohly@...el.com,
	netdev@...r.kernel.org, gospo@...hat.com,
	mitch.a.williams@...el.com
Subject: Re: [net-next PATCH] igb: remove skb_orphan calls

Duyck, Alexander H <alexander.h.duyck@...el.com> wrote:
>
> This patch was meant to be more general than just timestamping.  I was just using timestamping as one example of where things can go wrong due to the skb_orphan call.  The main problem is triggering desctructors and removing the sk can cause multiple issues with any custom use of the skb.  It is easiest to avoid those by not calling skb_orphan in the first place.

It doesn't matter what those custom uses are, what Dave was saying
is that we're thinking of killing skb->sk before it even gets to
the driver.  So even if such custom uses existed (which AFAIK do
not), we'd been looking at killing them as well.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html