netdev - RE: [net-next PATCH] igb: remove skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <80769D7B14936844A23C0C43D9FBCF0F283B712F@orsmsx501.amr.corp.intel.com>
Date:	Fri, 27 Feb 2009 08:39:30 -0800
From:	"Duyck, Alexander H" <alexander.h.duyck@...el.com>
To:	Herbert Xu <herbert@...dor.apana.org.au>
CC:	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
	"davem@...emloft.net" <davem@...emloft.net>,
	"Tantilov, Emil S" <emil.s.tantilov@...el.com>,
	"Ohly, Patrick" <patrick.ohly@...el.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"gospo@...hat.com" <gospo@...hat.com>,
	"Williams, Mitch A" <mitch.a.williams@...el.com>
Subject: RE: [net-next PATCH] igb: remove skb_orphan calls

Herbert Xu wrote:
> Duyck, Alexander H <alexander.h.duyck@...el.com> wrote:
>> 
>> This patch was meant to be more general than just timestamping.  I
>> was just using timestamping as one example of where things can go
>> wrong due to the skb_orphan call.  The main problem is triggering
>> desctructors and removing the sk can cause multiple issues with any
>> custom use of the skb.  It is easiest to avoid those by not calling
>> skb_orphan in the first place.     
> 
> It doesn't matter what those custom uses are, what Dave was saying
> is that we're thinking of killing skb->sk before it even gets to
> the driver.  So even if such custom uses existed (which AFAIK do
> not), we'd been looking at killing them as well.

The fact is, if you are planning to kill it further up the stack, you can put that down as another reason for removing the call.  The timesync / killing skb->sk is a separate discussion that I don't know if I even really need to be involved in.  The patch doesn't break anything, and removes a call to skb_orphan that shouldn't really be there in the first place.

Thanks,

Alex

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html