netdev - Re: pull request: wireless-next-2.6 2009-02-23

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <43e72e890902261918p47e45b14i7528dd0f40685879@mail.gmail.com>
Date:	Thu, 26 Feb 2009 19:18:49 -0800
From:	"Luis R. Rodriguez" <mcgrof@...il.com>
To:	Johannes Berg <johannes@...solutions.net>
Cc:	"John W. Linville" <linville@...driver.com>,
	David Miller <davem@...emloft.net>,
	linux-wireless@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: pull request: wireless-next-2.6 2009-02-23

On Thu, Feb 26, 2009 at 5:37 PM, Johannes Berg
<johannes@...solutions.net> wrote:
> On Thu, 2009-02-26 at 11:13 -0500, John W. Linville wrote:
>
>> > Now I just have to get around to fixing it, it's proving to be harder
>> > than I thought, and I don't have much time right now.
>>
>> I suppose I could just drop that one.  IIRC there was another patch
>> from you that depended upon that one as well?
>
> Ok, so I looked into this, and it turns out that it's harder to fix than
> I thought. Fixing the genl code to call the pre_dumpit at the right
> place is hard and requires netlink (not genl) changes. I'm not in a
> position to do such changes right now, so I would suggest to revert it,
> and for now take the easy way of restructuring nl80211 to take, in each
> operation, the rtnl before any other locks instead of trying to do this
> generically.
>
> Luis, would you be up to that? Basically go from
>
>        mutex_lock(&cfg80211_mtx)
>        ...
>        rtnl_lock()
>        ...
>        rtnl_unlock()
>        ...
>        mutex_unlock(&cfg80211_mtx)
>
> to
>
>        rtnl_lock()
>        ...
>        mutex_lock(&cfg80211_mtx)
>        ...
>        mutex_unlock(&cfg80211_mtx)
>        ...
>        rtnl_unlock()
>
> everywhere.

Sure, I'll give it a shot tomorrow unless someone else gets to it first.

  Luis
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html