netdev - Re: pull request: wireless-next-2.6 2009-02-23

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1235698640.4936.6.camel@johannes.local>
Date:	Thu, 26 Feb 2009 17:37:20 -0800
From:	Johannes Berg <johannes@...solutions.net>
To:	"John W. Linville" <linville@...driver.com>
Cc:	David Miller <davem@...emloft.net>, linux-wireless@...r.kernel.org,
	netdev@...r.kernel.org, mcgrof <mcgrof@...il.com>
Subject: Re: pull request: wireless-next-2.6 2009-02-23

On Thu, 2009-02-26 at 11:13 -0500, John W. Linville wrote:

> > Now I just have to get around to fixing it, it's proving to be harder
> > than I thought, and I don't have much time right now.
> 
> I suppose I could just drop that one.  IIRC there was another patch
> from you that depended upon that one as well?

Ok, so I looked into this, and it turns out that it's harder to fix than
I thought. Fixing the genl code to call the pre_dumpit at the right
place is hard and requires netlink (not genl) changes. I'm not in a
position to do such changes right now, so I would suggest to revert it,
and for now take the easy way of restructuring nl80211 to take, in each
operation, the rtnl before any other locks instead of trying to do this
generically.

Luis, would you be up to that? Basically go from

        mutex_lock(&cfg80211_mtx)
        ...
        rtnl_lock()
        ...
        rtnl_unlock()
        ...
        mutex_unlock(&cfg80211_mtx)

to

        rtnl_lock()
        ...
        mutex_lock(&cfg80211_mtx)
        ...
        mutex_unlock(&cfg80211_mtx)
        ...
        rtnl_unlock()

everywhere.

johannes

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)