[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <m163iwf3w3.fsf@fess.ebiederm.org>
Date: Fri, 27 Feb 2009 04:41:48 -0800
From: ebiederm@...ssion.com (Eric W. Biederman)
To: David Miller <davem@...emloft.net>
Cc: netdev@...r.kernel.org, containers@...ts.osdl.org
Subject: Re: [PATCH 2/2] veth: Configurable nterface MTU
David Miller <davem@...emloft.net> writes:
> From: ebiederm@...ssion.com (Eric W. Biederman)
> Date: Wed, 25 Feb 2009 21:49:04 -0800
>
>> @@ -249,6 +253,19 @@ static int veth_close(struct net_device *dev)
>> return 0;
>> }
>>
>> +static int is_valid_veth_mtu(int new_mtu)
>> +{
>> + return (new_mtu >= MIN_MTU && new_mtu <= MAX_MTU);
>> +}
>> +
>> +static int veth_change_mtu(struct net_device *dev, int new_mtu)
>> +{
>> + if (is_valid_veth_mtu(new_mtu))
>> + return -EINVAL;
>> + dev->mtu = new_mtu;
>> + return 0;
>> +}
>> +
>
> This validity test seems to be reversed?
Crap. You are correct. I will respin.
Eric
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists