netdev - Re: [PATCH 2/2] veth: Configurable nterface MTU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090227.052246.177817156.davem@davemloft.net>
Date:	Fri, 27 Feb 2009 05:22:46 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	ebiederm@...ssion.com
Cc:	netdev@...r.kernel.org, containers@...ts.osdl.org
Subject: Re: [PATCH 2/2] veth: Configurable nterface MTU

From: ebiederm@...ssion.com (Eric W. Biederman)
Date: Fri, 27 Feb 2009 04:41:48 -0800

> David Miller <davem@...emloft.net> writes:
> 
> > From: ebiederm@...ssion.com (Eric W. Biederman)
> > Date: Wed, 25 Feb 2009 21:49:04 -0800
> >
> >> @@ -249,6 +253,19 @@ static int veth_close(struct net_device *dev)
> >>  	return 0;
> >>  }
> >>  
> >> +static int is_valid_veth_mtu(int new_mtu)
> >> +{
> >> +	return (new_mtu >= MIN_MTU && new_mtu <= MAX_MTU);
> >> +}
> >> +
> >> +static int veth_change_mtu(struct net_device *dev, int new_mtu)
> >> +{
> >> +	if (is_valid_veth_mtu(new_mtu))
> >> +		return -EINVAL;
> >> +	dev->mtu = new_mtu;
> >> +	return 0;
> >> +}
> >> +
> >
> > This validity test seems to be reversed?
> 
> Crap.  You are correct. I will respin.

Please test your patches.

This one obviously didn't get even one single "ifconfig x mtu y" type
test.  It would have failed on any in-range value.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html