netdev - Re: [PATCH] netlink: invert error code in netlink_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090303.233740.206627831.davem@davemloft.net>
Date:	Tue, 03 Mar 2009 23:37:40 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	pablo@...filter.org
Cc:	netdev@...r.kernel.org, kaber@...sh.net
Subject: Re: [PATCH] netlink: invert error code in netlink_set_err()

From: Pablo Neira Ayuso <pablo@...filter.org>
Date: Wed, 04 Mar 2009 00:35:35 +0100

> The callers of netlink_set_err() currently pass a negative value
> as parameter for the error code. However, sk->sk_err wants a
> positive error value. Without this patch, skb_recv_datagram() called
> by netlink_recvmsg() may return a positive value to report an error.
> 
> Another choice to fix this is to change callers to pass a positive
> error value, but this seems a bit inconsistent and error prone
> to me. Indeed, the callers of netlink_set_err() assumed that the
> (usual) negative value for error codes was fine before this patch :).
> 
> This patch also includes some documentation in docbook format
> for netlink_set_err() to avoid this sort of confusion.
> 
> Signed-off-by: Pablo Neira Ayuso <pablo@...filter.org>

Applied, thanks a lot Pablo.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html