netdev - Re: [PATCH] cipso: subtraction on unsigned hdr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090303.234208.199560892.davem@davemloft.net>
Date:	Tue, 03 Mar 2009 23:42:08 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	roel.kluin@...il.com
Cc:	paul.moore@...com, netdev@...r.kernel.org,
	akpm@...ux-foundation.org
Subject: Re: [PATCH] cipso: subtraction on unsigned hdr_delta

From: Roel Kluin <roel.kluin@...il.com>
Date: Tue, 03 Mar 2009 23:23:38 +0100

> hdr_delta is unsigned, so take care not to subtract below 0.
> 
> Signed-off-by: Roel Kluin <roel.kluin@...il.com>

I'd like Paul to look at this.

It looks like it does the wrong thing when the option space increases,
which would have made hdr_delta negative if it were of a signed type.

I think therefore that sk_conn->icsk_ext_hdr_len needs to be adjusted
in both directions, just just when the option area length shrinks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html