netdev - Re: [PATCH 1/3] be2net: header files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20090303.234700.198045916.davem@davemloft.net>
Date:	Tue, 03 Mar 2009 23:47:00 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	sathyap@...verengines.com
Cc:	netdev@...r.kernel.org, jgarzik@...ox.com, subbus@...verengines.com
Subject: Re: [PATCH 1/3] be2net: header files

From: Sathya Perla <sathyap@...verengines.com>
Date: Tue, 03 Mar 2009 19:03:30 +0530

> +struct be_ctrl_info {
> +	u8 __iomem *csr;
> +	u8 __iomem *db;		/* Door Bell */
> +	u8 __iomem *pcicfg;	/* PCI config space */

Although these pointers are properly declared with the __iomem
marker, the code in some places fails to specify the __iomem
qualifier.

For example, be_mbox_db_ring(), be_mbox_db_ready_wait().

I am sure there are others.

If you check your driver's build with sparse it will warn about these
kinds of problems.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html