netdev - Re: [PATCH 6/13] forcedeth: add/modify tx done with limit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090310.053212.39968484.davem@davemloft.net>
Date:	Tue, 10 Mar 2009 05:32:12 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	aabdulla@...dia.com
Cc:	manfred@...orfullife.com, jgarzik@...ox.com, akpm@...l.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH 6/13] forcedeth: add/modify tx done with limit

From: Ayaz Abdulla <aabdulla@...dia.com>
Date: Thu, 05 Mar 2009 13:02:10 -0500

> There are two tx_done routines to handle tx completion processing. Both these functions now take in a limit value and return the amount of tx completions. This will be used by a future patch to determine the total amount of work done.
> 
> Signed-off-by: Ayaz Abdulla <aabdulla@...dia.com>

Applied.

But I would absolutely not count TX completion processing in the
NAPI work limit as you do in one of the subsequent patches.

TX completely is just buffer freeing, very cheap.

Whereas RX processing involves actually network stack processing
which is real work and is what NAPI should be limiting.

Also, please get rid of the NAPI config option for this driver and
make NAPI unconditionally enabled.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html