netdev - Re: [PATCH 6/13] forcedeth: add/modify tx done with limit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 10 Mar 2009 06:17:52 -0500
From:	Ayaz Abdulla <aabdulla@...dia.com>
To:	David Miller <davem@...emloft.net>
CC:	"manfred@...orfullife.com" <manfred@...orfullife.com>,
	"jgarzik@...ox.com" <jgarzik@...ox.com>,
	"akpm@...l.org" <akpm@...l.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH 6/13] forcedeth: add/modify tx done with limit



David Miller wrote:
> From: Ayaz Abdulla <aabdulla@...dia.com>
> Date: Thu, 05 Mar 2009 13:02:10 -0500
> 
> 
>>There are two tx_done routines to handle tx completion processing. Both these functions now take in a limit value and return the amount of tx completions. This will be used by a future patch to determine the total amount of work done.
>>
>>Signed-off-by: Ayaz Abdulla <aabdulla@...dia.com>
> 
> 
> Applied.
> 
> But I would absolutely not count TX completion processing in the
> NAPI work limit as you do in one of the subsequent patches.
> 

I agree. However, I am counting tx work only for the purpose of 
interrupt moderation.  The tx work count is not included in the NAPI 
limit check.
ie.

+	nv_change_interrupt_mode(dev, tx_work + rx_work);

-	if (pkts < budget) {
+	if (rx_work < budget) {


> TX completely is just buffer freeing, very cheap.
> 
> Whereas RX processing involves actually network stack processing
> which is real work and is what NAPI should be limiting.
> 
> Also, please get rid of the NAPI config option for this driver and
> make NAPI unconditionally enabled.
> 

Sure, I will submit a new patch for removing the config option.

> Thanks.

-----------------------------------------------------------------------------------
This email message is for the sole use of the intended recipient(s) and may contain
confidential information.  Any unauthorized review, use, disclosure or distribution
is prohibited.  If you are not the intended recipient, please contact the sender by
reply email and destroy all copies of the original message.
-----------------------------------------------------------------------------------
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html