[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20090313.121438.17663218.davem@davemloft.net>
Date: Fri, 13 Mar 2009 12:14:38 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: steve.glendinning@...c.com
Cc: netdev@...r.kernel.org, roel.kluin@...il.com,
juha_motorsportcom@...kku.com, ian.saturley@...c.com
Subject: Re: [PATCH 1/2] smsc911x: check for FFWD success before checking
for timeout
From: Steve Glendinning <steve.glendinning@...c.com>
Date: Wed, 4 Mar 2009 17:33:24 +0000
> This patch from Juha Leppanen suppresses a false warning if a fast
> forward operation succeeds on the very last attempt.
>
> Juha> If smsc911x_reg_read loop is executed 500 times, timeout reaches 0
> Juha> and the 500th smsc911x_reg_read result in val is ignored. If
> Juha> testing order is changed, then val is checked first. The 500th
> Juha> reg_read might be GOOD, why ignore it!
>
> Signed-off-by: Steve Glendinning <steve.glendinning@...c.com>
Applied to net-next-2.6
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists