netdev - Re: [PATCH 2/2] smsc911x: improve EEPROM loading timeout logic in open

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20090313.121447.186963981.davem@davemloft.net>
Date:	Fri, 13 Mar 2009 12:14:47 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	steve.glendinning@...c.com
Cc:	netdev@...r.kernel.org, roel.kluin@...il.com,
	juha_motorsportcom@...kku.com, ian.saturley@...c.com
Subject: Re: [PATCH 2/2] smsc911x: improve EEPROM loading timeout logic in
 open

From: Steve Glendinning <steve.glendinning@...c.com>
Date: Wed,  4 Mar 2009 17:33:25 +0000

> This patch from Juha Leppanen suppresses a false warning if the eeprom
> load succeeds on the very last attempt.
> 
> Juha> In function smsc911x_open smsc911x_reg_read+udelay can be run 50
> Juha> times with timeout reaching -1, and the following if statetement
> Juha> does not catch the timeout and no warning is issued. Also if the
> Juha> 50th smsc911x_reg_read is GOOD, loop is exited with timeout as 0
> Juha> and bogus warning issued.  Replace testing order and --timeout
> Juha> instead of timeout-- and now max 50 smsc911x_reg_read's are done,
> Juha> with max 49 udelays.
> 
> Signed-off-by: Steve Glendinning <steve.glendinning@...c.com>

Applied to net-next-2.6
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html