netdev - Re: [PATCH] mv643xx_eth: fix unicast address filter corruption on mtu change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20090313.154813.05867923.davem@davemloft.net>
Date:	Fri, 13 Mar 2009 15:48:13 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	buytenh@...tstofly.org
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] mv643xx_eth: fix unicast address filter corruption on
 mtu change

From: Lennert Buytenhek <buytenh@...tstofly.org>
Date: Tue, 10 Mar 2009 09:22:48 +0100

> When mv643xx_eth_open() is called to up an interface, port_start()
> will first re-program the unicast address filter, and then
> re-initialise the PORT_CONFIG register, but that will disable unicast
> promiscuous mode if it was enabled by the unicast address filter setup.
> 
> This isn't a problem on ifconfig up, as ->set_rx_mode() will be called
> shortly afterwards which will program the filters again, but it does
> trigger when changing the MTU, which calls mv643xx_eth_stop() and then
> mv643xx_eth_open() by hand to repopulate the receive rings with skbuffs
> of the new size.
> 
> Swap the initialisation of the PORT_START register and the call to
> the unicast filter setup function to fix this.
> 
> Signed-off-by: Lennert Buytenhek <buytenh@...vell.com>

Applied, thanks Lennert!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html