netdev - Re: 3c59x: shared interrupt problem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090313.155116.183062617.davem@davemloft.net>
Date:	Fri, 13 Mar 2009 15:51:16 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	klassert@...hematik.tu-chemnitz.de
Cc:	akpm@...ux-foundation.org, shemminger@...tta.com,
	gerhard_pircher@....net, netdev@...r.kernel.org
Subject: Re: 3c59x: shared interrupt problem

From: Steffen Klassert <klassert@...hematik.tu-chemnitz.de>
Date: Wed, 11 Mar 2009 12:38:15 +0100

> On Tue, Mar 10, 2009 at 02:55:42PM -0700, Andrew Morton wrote:
> > > 
> > > This basically reverts a patch from akpm (bitkeeper cset 1.1046.95.8)
> > > This patch was to workaround lots of "nobody cared" warnings generated by
> > > boomerang_interrupt(). 
> > > I added Andrew to the Cc, perhaps he can remember some details on this.
> > > 
> > 
> > Beats me.  Do you havea full copy of that patch, including changelog?
> > 
> 
> It was this one:
> 
> #### ChangeSet ####
> 2003-05-19 10:27:49-07:00, akpm@...eo.com 
>   [PATCH] 3c59x irqreturn fix
>   
>   Apparently boomerang_interrupt() is generating lots of "nobody cared"
>   warnings - one per packet it seems.  Frankly, I don't have a clue why.
>   
>   These are ancient cards and the driver is otherwise stable, so just
>   change it to return IRQ_HANDLED and move on...

So basically it's a band-aid because we didn't investigate why
this happens.

I think we should put the change in, and then look into things
properly if users report this issue again.

The code there right now is just completely wrong when the
3c59x interrupt is shared with another device.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html