netdev - Re: 3c59x: shared interrupt problem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090314140841.GA17629@bayes.mathematik.tu-chemnitz.de>
Date:	Sat, 14 Mar 2009 15:08:41 +0100
From:	Steffen Klassert <klassert@...hematik.tu-chemnitz.de>
To:	David Miller <davem@...emloft.net>
Cc:	akpm@...ux-foundation.org, shemminger@...tta.com,
	gerhard_pircher@....net, netdev@...r.kernel.org
Subject: Re: 3c59x: shared interrupt problem

On Fri, Mar 13, 2009 at 03:51:16PM -0700, David Miller wrote:
> > #### ChangeSet ####
> > 2003-05-19 10:27:49-07:00, akpm@...eo.com 
> >   [PATCH] 3c59x irqreturn fix
> >   
> >   Apparently boomerang_interrupt() is generating lots of "nobody cared"
> >   warnings - one per packet it seems.  Frankly, I don't have a clue why.
> >   
> >   These are ancient cards and the driver is otherwise stable, so just
> >   change it to return IRQ_HANDLED and move on...
> 
> So basically it's a band-aid because we didn't investigate why
> this happens.
> 
> I think we should put the change in, and then look into things
> properly if users report this issue again.
> 

Gerhard reported at least one of these "nobody cared" messages at shutdown
after applying this change. He wanted to provide us with further informations
about this issue next week. Best would be to put it in together with a fix.
So I would suggest to wait, perhaps we can fix it with his informations. 


> The code there right now is just completely wrong when the
> 3c59x interrupt is shared with another device.

Indeed.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html