netdev - Re: [NET] net: reorder struct net_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49C391D9.20308@cosmosbay.com>
Date:	Fri, 20 Mar 2009 13:53:45 +0100
From:	Eric Dumazet <dada1@...mosbay.com>
To:	Bjørn Mork <bjorn@...k.no>
CC:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [NET] net: reorder struct net_device_ops

Bjørn Mork a écrit :
> Eric Dumazet <dada1@...mosbay.com> writes:
> 
>> [NET] net: reorder struct net_device_ops
>>
>> Moving ndo_start_xmit() field at first position in
>> struct net_device_ops reduce the assembly needed to compute
>> the prefetch() address.
> 
> You can't do this while the compatibility code is still there.
> 
> from net/core/dev.c:register_netdevice() :
> 
> 		/* This works only because net_device_ops and the
> 		   compatiablity structure are the same. */
> 		dev->netdev_ops = (void *) &(dev->init);
> 
> 
> Bjørn

Nice catch !

Yes, very true, but I discarded this patch anyway, I wont correct this.

Thank you


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html