netdev - Re: [PATCH] net: remove useless prefetch() call

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20090321.134310.200703901.davem@davemloft.net>
Date:	Sat, 21 Mar 2009 13:43:10 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	dada1@...mosbay.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] net: remove useless prefetch() call

From: Eric Dumazet <dada1@...mosbay.com>
Date: Fri, 20 Mar 2009 11:07:33 +0100

> So first patch is OK, what about this updated Changelog ?
> 
> [PATCH] net: remove useless prefetch() call
> 
> There is no gain using prefetch() in dev_hard_start_xmit(), since
> we already had to read ops->ndo_select_queue pointer in dev_pick_tx(),
> and both pointers are probably located in the same cache line.
> 
> This prefetch call slows down fast path because of a stall in address
> computation.

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html