netdev - Re: [patch] xfrm: spin_lock() should be spin_unlock() in xfrm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090327011654.GA24848@gondor.apana.org.au>
Date:	Fri, 27 Mar 2009 09:16:54 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Chuck Ebbert <cebbert@...hat.com>
Cc:	netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>
Subject: Re: [patch] xfrm: spin_lock() should be spin_unlock() in
	xfrm_state.c

On Thu, Mar 26, 2009 at 06:58:45PM -0400, Chuck Ebbert wrote:
> xfrm: spin_lock() should be spin_unlock() in xfrm_state.c
> 
> spin_lock() should be spin_unlock() in xfrm_state_walk_done().
> 
> caused by:
> commit 12a169e7d8f4b1c95252d8b04ed0f1033ed7cfe2
> "ipsec: Put dumpers on the dump list"
> 
> Reported-by: Marc Milgram <mmilgram@...hat.com>
> Signed-off-by: Chuck Ebbert <cebbert@...hat.com>
> ---
> 
> --- linux-2.6.29.noarch.orig/net/xfrm/xfrm_state.c
> +++ linux-2.6.29.noarch/net/xfrm/xfrm_state.c
> @@ -1615,7 +1615,7 @@ void xfrm_state_walk_done(struct xfrm_st
>  
>  	spin_lock_bh(&xfrm_state_lock);
>  	list_del(&walk->all);
> -	spin_lock_bh(&xfrm_state_lock);
> +	spin_unlock_bh(&xfrm_state_lock);
>  }
>  EXPORT_SYMBOL(xfrm_state_walk_done);

Good catch!

Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html