netdev - Re: [PATCH 2/6] mlx4_en: Separating default QP in RSS context

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090327.003544.79654528.davem@davemloft.net>
Date:	Fri, 27 Mar 2009 00:35:44 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	yevgenyp@...lanox.co.il
Cc:	netdev@...r.kernel.org, tziporet@...lanox.co.il
Subject: Re: [PATCH 2/6] mlx4_en: Separating default QP in RSS context

From: Yevgeny Petrilin <yevgenyp@...lanox.co.il>
Date: Thu, 26 Mar 2009 15:49:31 +0200

> The default QP number in RSS is no longer part of the RSS table.
> We want to separate TCP streams from other streams because we
> want to handle them differently. Changed the RSS mask to perform
> the hashing on TCP packets only and to send all the others to the
> default ring.
> 
> Signed-off-by: Yevgeny Petrilin <yevgenyp@...lanox.co.il>

I disagree with this change.  I understand why you are doing
it, to implement your frag'd vs. non-frag'd skb patch coming
up.

But that doesn't make it any more right.

UDP and IPSEC traffic should be multiqueue balanced just like any
other traffic.

I'm not applying this patch set, sorry.

I'd also like to ask you to convert your driver over to GRO
instead of LRO which we are trying to deprecate.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html