netdev - Re: [PATCH 1/2 V3] kaweth: Fix locking to be SMP-safe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49D4D37A.50504@lwfinger.net>
Date:	Thu, 02 Apr 2009 10:02:18 -0500
From:	Larry Finger <Larry.Finger@...inger.net>
To:	Herbert Xu <herbert@...dor.apana.org.au>
CC:	davem@...emloft.net, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org, oliver@...kum.org
Subject: Re: [PATCH 1/2 V3] kaweth: Fix locking to be SMP-safe

Herbert Xu wrote:
> Larry Finger <Larry.Finger@...inger.net> wrote:
>> @@ -796,7 +795,7 @@ static int kaweth_start_xmit(struct sk_b
>>
>>        int res;
>>
>> -       spin_lock(&kaweth->device_lock);
>> +       spin_lock_irq(&kaweth->device_lock);
> 
> Should be irqsave unless you don't expect to be called via netpoll.

The .ndo_poll_controller callback is left at NULL in this driver. I believe the
patch to be OK.

Larry
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html