netdev - Re: [PATCH 1/2 V3] kaweth: Fix locking to be SMP-safe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090402100223.GA30905@gondor.apana.org.au>
Date:	Thu, 2 Apr 2009 18:02:23 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Larry Finger <Larry.Finger@...inger.net>
Cc:	davem@...emloft.net, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org, oliver@...kum.org
Subject: Re: [PATCH 1/2 V3] kaweth: Fix locking to be SMP-safe

Larry Finger <Larry.Finger@...inger.net> wrote:
>
> @@ -796,7 +795,7 @@ static int kaweth_start_xmit(struct sk_b
> 
>        int res;
> 
> -       spin_lock(&kaweth->device_lock);
> +       spin_lock_irq(&kaweth->device_lock);

Should be irqsave unless you don't expect to be called via netpoll.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html