netdev - RE: [PATCH] ixgbe: missing parentheses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <A78C6259B11833419567082E2DC0C256CB288425@orsmsx508.amr.corp.intel.com>
Date:	Thu, 16 Apr 2009 14:25:44 -0700
From:	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>
To:	Andrew Morton <akpm@...ux-foundation.org>,
	Roel Kluin <roel.kluin@...il.com>
CC:	"e1000-devel@...ts.sourceforge.net" 
	<e1000-devel@...ts.sourceforge.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH] ixgbe: missing parentheses

>On Thursday, April 16, 2009 Andrew Morton wrote:
>
>(cc netdev)
>
>On Thu, 16 Apr 2009 23:05:00 +0200
>Roel Kluin <roel.kluin@...il.com> wrote:
>
>> `!' has a higher precedence than `&'
>>
>> Signed-off-by: Roel Kluin <roel.kluin@...il.com>
>> ---
>> diff --git a/drivers/net/ixgbe/ixgbe_main.c b/drivers/net/ixgbe/ixgbe_main.c
>> index febde45..49a9037 100644
>> --- a/drivers/net/ixgbe/ixgbe_main.c
>> +++ b/drivers/net/ixgbe/ixgbe_main.c
>> @@ -3946,7 +3946,7 @@ static void ixgbe_sfp_config_module_task(struct
>work_struct *work)
>>  	}
>>  	hw->mac.ops.setup_sfp(hw);
>>
>> -	if (!adapter->flags & IXGBE_FLAG_IN_SFP_LINK_TASK)
>> +	if (!(adapter->flags & IXGBE_FLAG_IN_SFP_LINK_TASK))
>>  		/* This will also work for DA Twinax connections */
>>  		schedule_work(&adapter->multispeed_fiber_task);
>>  	adapter->flags &= ~IXGBE_FLAG_IN_SFP_MOD_TASK;
>
>This is fixed in linux-next, but hasn't been pushed to Linus yet.

Yes, Dave has this fix in his net-next-2.6 tree.

Dave - Can we pull this fix into net-2.6?

Cheers,
Jeff

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html