netdev - Re: [PATCH] ixgbe: missing parentheses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090416.160338.35558187.davem@davemloft.net>
Date:	Thu, 16 Apr 2009 16:03:38 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	akpm@...ux-foundation.org
Cc:	roel.kluin@...il.com, jeffrey.t.kirsher@...el.com,
	e1000-devel@...ts.sourceforge.net, netdev@...r.kernel.org
Subject: Re: [PATCH] ixgbe: missing parentheses

From: Andrew Morton <akpm@...ux-foundation.org>
Date: Thu, 16 Apr 2009 14:16:10 -0700

>> @@ -3946,7 +3946,7 @@ static void ixgbe_sfp_config_module_task(struct work_struct *work)
>>  	}
>>  	hw->mac.ops.setup_sfp(hw);
>>  
>> -	if (!adapter->flags & IXGBE_FLAG_IN_SFP_LINK_TASK)
>> +	if (!(adapter->flags & IXGBE_FLAG_IN_SFP_LINK_TASK))
>>  		/* This will also work for DA Twinax connections */
>>  		schedule_work(&adapter->multispeed_fiber_task);
>>  	adapter->flags &= ~IXGBE_FLAG_IN_SFP_MOD_TASK;
> 
> This is fixed in linux-next, but hasn't been pushed to Linus yet.

If I recall correctly, this got submitted to me as a net-next-2.6 only
patch, which obviously isn't correct.

Intel folks, please resubmit this to me for net-2.6 too, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html