netdev - Re: PATCH: Multicast: Filter multicast traffic per socket mc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.1.10.0904161137080.15629@qirst.com>
Date:	Thu, 16 Apr 2009 11:39:30 -0400 (EDT)
From:	Christoph Lameter <cl@...ux.com>
To:	Vlad Yasevich <vladislav.yasevich@...com>
cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
	nhorman@...driver.com, dlstevens@...ibm.com
Subject: Re: PATCH: Multicast: Filter multicast traffic per socket mc_list

On Thu, 16 Apr 2009, Vlad Yasevich wrote:

> > -	if (!ipv4_is_multicast(loc_addr))
> > +	if (ipv4_is_lbcast(loc_addr) || !ipv4_is_multicast(loc_addr))
> >  		return 1;
>
> I don't think this change is needed.  ipv4_is_lbcast() checks if the
> address is 255.255.255.255.  That address is already !ipv4_is_multicast().
>
> Subnet broadcasts are also !ipv4_is_multicast.

ok will drop this.

> >  	{
> >  		struct msghdr msg;
>
> You might need to set inet->mc_all to 1 in inet_create() since I am not sure if
> we want to change the default behavior.  The knowledge that some apps have
> a very "unique" way of doing multicast makes me a little hesitant.

Those "unique" applications would only be able to run on Linux.
Application mostly are written for multiple Unix variants. Since the
other Unix variants have changed their default behavior it is reasonable
to also change the default under Linux.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html