netdev - Re: PATCH: Multicast: Filter multicast traffic per socket mc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090416174422.GB28978@hmsreliant.think-freely.org>
Date:	Thu, 16 Apr 2009 13:44:22 -0400
From:	Neil Horman <nhorman@...driver.com>
To:	Christoph Lameter <cl@...ux.com>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
	vladislav.yasevich@...com, dlstevens@...ibm.com
Subject: Re: PATCH: Multicast: Filter multicast traffic per socket mc_list

On Thu, Apr 16, 2009 at 11:36:56AM -0400, Christoph Lameter wrote:
> On Thu, 16 Apr 2009, Neil Horman wrote:
> 
> > I think your comment is reveresed here isn't it?  the default you have below is
> > that mc_all is set, which defaults you to the existing behavior, rather than the
> > new behavior introduced by this patch.
> 
> mc_all is 0 by default.
> 
> > Ack to the patch though
> > Acked-by: Neil Horman <nhorman@...driver.com>
> > Neil
> 
> Thanks.
> 
I'm sorry, I misread it (confused the definiton of a bitfield with its default
value.  As Dave noted, the default needs to be the current behavior, not your
new behavior.  Until thats changed, I rescind my Ack
Neil

> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html