netdev - Re: [PATCH] net: Fix GRO for multiple page fragments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090417144812.GC4182@gondor.apana.org.au>
Date:	Fri, 17 Apr 2009 22:48:12 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Ben Hutchings <bhutchings@...arflare.com>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH] net: Fix GRO for multiple page fragments

On Fri, Apr 17, 2009 at 03:03:30PM +0100, Ben Hutchings wrote:
>
> The loop is iterating forward, not backward, so why initialise frag to
> point to the last fragment?

Ah yes, that's completely bogus.  I suppose it only works because
the current users only supply one frag under normal circumstanses.

Yes we should integrate your patch for 2.6.30.  For net-next the
loop no longer exists so it should be fine.

Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html