netdev - Re: [PATCH] net: Fix GRO for multiple page fragments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20090420.022403.194348592.davem@davemloft.net>
Date:	Mon, 20 Apr 2009 02:24:03 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	herbert@...dor.apana.org.au
Cc:	bhutchings@...arflare.com, netdev@...r.kernel.org
Subject: Re: [PATCH] net: Fix GRO for multiple page fragments

From: Herbert Xu <herbert@...dor.apana.org.au>
Date: Fri, 17 Apr 2009 22:48:12 +0800

> On Fri, Apr 17, 2009 at 03:03:30PM +0100, Ben Hutchings wrote:
>>
>> The loop is iterating forward, not backward, so why initialise frag to
>> point to the last fragment?
> 
> Ah yes, that's completely bogus.  I suppose it only works because
> the current users only supply one frag under normal circumstanses.
> 
> Yes we should integrate your patch for 2.6.30.  For net-next the
> loop no longer exists so it should be fine.

I've applied Ben's patch.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html